project-codeflare / multi-cluster-app-dispatcher

Holistic job manager on Kubernetes
Apache License 2.0
108 stars 63 forks source link

remove threads, fix backoff #623

Closed asm582 closed 1 year ago

asm582 commented 1 year ago

Issue link

618 #515

What changes have been made

Independent go routines performing backoff have been removed, and an informer has been used to re-queue AWs for backoff.

Verification steps

I have run manual tests to confirm that AW gets re-dispatched after configurable backoff seconds.

Checks

astefanutti commented 1 year ago

/lgtm

astefanutti commented 1 year ago

/approve

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/project-codeflare/multi-cluster-app-dispatcher/blob/main/OWNERS)~~ [astefanutti] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment