project-codeflare / multi-cluster-app-dispatcher

Holistic job manager on Kubernetes

Apache License 2.0

108 stars 63 forks source link

Expose structured configuration #630

Closed astefanutti closed 1 year ago

astefanutti commented 1 year ago

Issue link

Closes #622

What changes have been made

Expose a structured configuration API
Adapt server.go to convert CLI options to structured configuration

astefanutti commented 1 year ago

/assign @anishasthana @asm582

asm582 commented 1 year ago

@astefanutti CLI options are used in helm deployment, After this PR can you please tell us what would change wrt helm deployment mode?

astefanutti commented 1 year ago

@astefanutti CLI options are used in helm deployment, After this PR can you please tell us what would change wrt helm deployment mode?

@asm582 This PR maintains backward compatibility w.r.t. local development, so the Helm deployment is expected to continue working as before.

asm582 commented 1 year ago

/LGTM

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/project-codeflare/multi-cluster-app-dispatcher/blob/main/OWNERS)~~ [anishasthana] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment