search

project-codeflare / multi-cluster-app-dispatcher

Holistic job manager on Kubernetes
Apache License 2.0
108 stars 63 forks source link

fix: issue formatting log message #636

Closed VanillaSpoon closed 1 year ago

VanillaSpoon commented 1 year ago

What changes have been made

Just a small fix for the formatting of a log message. klog.Info doesn't support string formatting and will therefore display the log as [allocatableCapacity] The available capacity to dispatch appwrapper is %v and time took to calculate is %v ... without replacing the %v values.

I substituted time.Now().Sub(startTime) to time.Since(startTime) for readability.

Verification steps

Checks

astefanutti commented 1 year ago

/lgtm

astefanutti commented 1 year ago

Nice catch 👍🏼.

astefanutti commented 1 year ago

/approve

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/project-codeflare/multi-cluster-app-dispatcher/blob/main/OWNERS)~~ [astefanutti] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment