project-codeflare / multi-cluster-app-dispatcher

Holistic job manager on Kubernetes

Apache License 2.0

107 stars 63 forks source link

MCAD deployment in custom namespace #656

Open metalcycling opened 12 months ago

metalcycling commented 12 months ago

What changes have been made

Installing MCAD always happens in the kube-system namespace. This update allows users to specify the namespace they want to use for the deployment.

Verification steps

Create a namespace called mcad and deployed MCAD there using the helm chart and --set namespace="mcad".

Checks

[ ] I've made sure the tests are passing.
Testing Strategy
- [ ] Unit tests
- [x] Manual tests
- [ ] Testing is not required for this change

openshift-ci[bot] commented 12 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from metalcycling. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/project-codeflare/multi-cluster-app-dispatcher/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

VanillaSpoon commented 11 months ago

/lgtm