Open Bobbins228 opened 11 months ago
@ChristianZaccaria Tested this out and it seems no matter the log level it will always print logs below its level. e.g. set log level to 6 you will get all logs below level 6 too.
I have opted to make warning logs like Failed to dispatch app wrapper due to insufficient resources
to have no log level so they are always printed.
More informational logs that are noisy have been bumped to log level 4
For example:
available resource successful check for appwrapper
has an increased log level because we would know if we did not have enough resources anyway.
/retest
Seems the CI is acting up. I'm pretty sure it has nothing to do with your changes.
Hey Mark, could you try change i.e., a comment or add a comment and push changes, just to trigger the CI again and see if it works. The /retest
option doesn't retrigger it for some reason
/retest
/retest
Hi @Bobbins228, I've ran MCAD locally with the debugger, and when I attempt to bring up a cluster object (cluster.up), it initially says there is insufficient resources to dispatch appwrapper. Then, I get the Raw of a GenericTemplate which are lots of numbers such as below: Would you know what could this be? I'll run MCAD on the cluster as opposed via the debugger but I assume same result.
@ChristianZaccaria What log level do you have your MCAD set to?
@ChristianZaccaria What log level do you have your MCAD set to?
On the debugger it's set to 15 by default, I thought that could be it but, update on my previous comment: With this PR I don't see the raw GenericTemplate on MCAD logs when ran in the cluster. However, when I run mcad (main branch) via the debugger, I don't get the Raw GenericTemplate. Something in this PR is causing the debugger to display that for some reason.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ChristianZaccaria Once this PR has been reviewed and has the lgtm label, please assign anishasthana for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Issue link
Closes #612
What changes have been made
Removed occurrences where an entire appwrapper is logged Bumped large informational logs up to level 4 and kept warning logs as level independent. Added new log which logs additional resources required for an appwrapper to be dispatched
Verification steps
Set the logging level for MCAD to be level 3 and check that level 3 related logs are accurate. Repeat with level 4 logs.
To verify the required resources log
Create an AppWrapper that has a large number of resources e.g. 8 GPUs you should receive a log like this:
Checks