project-codeflare / multi-cluster-app-dispatcher

Holistic job manager on Kubernetes
Apache License 2.0
108 stars 63 forks source link

remove: nodechecks function as it is not being used #683

Closed VanillaSpoon closed 1 year ago

VanillaSpoon commented 1 year ago

What changes have been made

Removal of the unused function

Checks

VanillaSpoon commented 1 year ago

/retest

ChristianZaccaria commented 1 year ago

@VanillaSpoon you can retest by adding a comment and pushing changes to this PR. /retest should work but I think there's some bug in the OpenShift CI that needs to be fixed. I created this issue to see if people have any comments on it: https://github.com/project-codeflare/multi-cluster-app-dispatcher/issues/685

astefanutti commented 1 year ago

/lgtm

astefanutti commented 1 year ago

/approve

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti, ChristianZaccaria

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/project-codeflare/multi-cluster-app-dispatcher/blob/main/OWNERS)~~ [astefanutti] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
astefanutti commented 1 year ago

cc: @astefanutti @z103cb interested in your thoughts on doing a complete clean-up on unused functions as a follow-up to this PR?

@ChristianZaccaria that sounds desirable / reasonable to me 👍🏼.