Open Fiona-Waters opened 10 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign asm582 for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Very awesome job @Fiona-Waters ! I left a few nitpicks and the comment below
I think this file should be addressed as well:
Thanks for the review. This issue wasn't fully completed but as we are moving to mcad v2 Anish suggested I create a PR with what was completed so far, but not to do any more. Therefore all files haven't been covered.
/LGTM
@z103cb: changing LGTM is restricted to collaborators
Issue link
Closes #613
What changes have been made
Added error handling and logging. This issue has not been fully completed as we will now be working on V2 of MCAD. Hoping to merge the work that was done before this decision was made.
Verification steps
Code review.
Checks