project-codeflare / multi-cluster-app-dispatcher

Holistic job manager on Kubernetes
Apache License 2.0
107 stars 63 forks source link

Adding error handling and logging #694

Open Fiona-Waters opened 10 months ago

Fiona-Waters commented 10 months ago

Issue link

Closes #613

What changes have been made

Added error handling and logging. This issue has not been fully completed as we will now be working on V2 of MCAD. Hoping to merge the work that was done before this decision was made.

Verification steps

Code review.

Checks

openshift-ci[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign asm582 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/project-codeflare/multi-cluster-app-dispatcher/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Fiona-Waters commented 10 months ago

Very awesome job @Fiona-Waters ! I left a few nitpicks and the comment below

I think this file should be addressed as well:

https://github.com/project-codeflare/multi-cluster-app-dispatcher/blob/41833f2bd925d39e7391165d402e4df76025a296/pkg/controller/quota/quotaforestmanager/qm_lib_backend_with_quotasubt_mgr.go#L603

Thanks for the review. This issue wasn't fully completed but as we are moving to mcad v2 Anish suggested I create a PR with what was completed so far, but not to do any more. Therefore all files haven't been covered.

z103cb commented 10 months ago

/LGTM

openshift-ci[bot] commented 10 months ago

@z103cb: changing LGTM is restricted to collaborators

In response to [this](https://github.com/project-codeflare/multi-cluster-app-dispatcher/pull/694#issuecomment-1842735814): >/LGTM Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.