project-codeflare / multi-cluster-app-dispatcher

Holistic job manager on Kubernetes
Apache License 2.0
108 stars 63 forks source link

Skipping MCAD CPU Preemption Test #696

Open Fiona-Waters opened 11 months ago

Fiona-Waters commented 11 months ago

Skipping the MCAD CPU Preemption Test which is failing intermittently on PRs so that we can get some outstanding PRs merged.

openshift-ci[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign anishasthana for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/project-codeflare/multi-cluster-app-dispatcher/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ronensc commented 11 months ago

For future reference, the root cause analysis of the test's failure has been conducted by @dgrove-oss, and it can be found here: https://github.com/project-codeflare/multi-cluster-app-dispatcher/pull/691#issuecomment-1832070420

Fiona-Waters commented 11 months ago

For future reference, the root cause analysis of the test's failure has been conducted by @dgrove-oss, and it can be found here: #691 (comment)

Thanks @ronensc That's good to know!

dgrove-oss commented 11 months ago

I don't think it's worth backporting, but I did redo these test cases for mcad v2 to be robust against different cluster sizes in https://github.com/project-codeflare/mcad/pull/83

Fiona-Waters commented 11 months ago

More investigation is required as to why these tests are failing. Closing this PR.