search

project-copacetic / copacetic

🧵 CLI tool for directly patching container images using reports from vulnerability scanners
https://project-copacetic.github.io/copacetic/
Apache License 2.0
845 stars 59 forks source link

[REQ] Add support for custom APT config and gpg key injection #600

Open ashnamehrotra opened 2 months ago

ashnamehrotra commented 2 months ago

What kind of request is this?

None

What is your request or suggestion?

https://github.com/project-copacetic/copacetic/blob/d648155f5424a9f4cb13acd7209195846791873b/pkg/pkgmgr/dpkg.go#L239C1-L240C1

Turning copacetic TODO comments into issues from https://docs.google.com/spreadsheets/d/1XwNj1J6e2FrUhlqaIsV10l8_tgov7WodlkvpNZXYZMU/edit#gid=1386834576.

Are you willing to submit PRs to contribute to this feature request?

h4l0gen commented 2 months ago

Hii @ashnamehrotra, In first look we want to extend user's control by giving them functionality for custom APT config file. If you have something in your mind regarding this which can help me to solve this issue, please tell me. So we can work on this in proper way.

ashnamehrotra commented 2 months ago

Hi @h4l0gen, based on the comment, I think we should set up the configuration within the original dm.config.ImageState prior to applying apt update on the resulting state based custom config input into Copa.

Akash-Singh04 commented 4 weeks ago

Hey is this issue still open?If so, I would like to work on it

ashnamehrotra commented 4 weeks ago

Hi @h4l0gen, are you still planning on working on this issue?

h4l0gen commented 3 weeks ago

Hi @ashnamehrotra @Akash-Singh04 I am really not able to find time these days. Akash please feel free to work on it. I will look into problem of my solution if i found time 🙂.

Akash-Singh04 commented 1 week ago

@ashnamehrotra kindly review and let me know if any more changes are required