project-copacetic / copacetic

🧵 CLI tool for directly patching container images using reports from vulnerability scanners
https://project-copacetic.github.io/copacetic/
Apache License 2.0
843 stars 57 forks source link

feat: Added check for binaries to skip "installToolsCmd" #670

Open Akash-Singh04 opened 2 weeks ago

Akash-Singh04 commented 2 weeks ago

Updated probeRPMStatus to check if binaries are present and only if not present to all installToolsCmd Closes #652 #651

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 33.96%. Comparing base (2602d59) to head (76752b6). Report is 88 commits behind head on main.

Files Patch % Lines
pkg/pkgmgr/rpm.go 0.00% 14 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #670 +/- ## ========================================== + Coverage 32.51% 33.96% +1.45% ========================================== Files 17 18 +1 Lines 1621 1534 -87 ========================================== - Hits 527 521 -6 + Misses 1062 980 -82 - Partials 32 33 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ashnamehrotra commented 2 weeks ago

@Akash-Singh04 is there a specific image we can test the changes with? Also its failing lint fix (you can run golangci-lint run) and the PR title is failing semantics check due to Feat vs feat.