Open shishir-11 opened 1 month ago
Attention: Patch coverage is 4.34783%
with 22 lines
in your changes missing coverage. Please review.
Project coverage is 34.02%. Comparing base (
9da1246
) to head (deb5e30
).
Files | Patch % | Lines |
---|---|---|
pkg/patch/patch.go | 0.00% | 21 Missing :warning: |
pkg/patch/cmd.go | 50.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
the lint check is failing on a piece of code that is unrelated to me ? can someone help me fix that or is it fine eitherways
@shishir-11 that lint error was fixed in #682, a rebase should fix that
@ashnamehrotra can you please check if this is fine or something more needs to be done, thank you.
@shishir-11 this looks good to me! I can do another review once the test pushed
@ashnamehrotra can you please take a look at the failing unit test , do you know why that might be happening , is it possible it lacks permissions to execute apk update
@ashnamehrotra can you please take a look at the failing unit test , do you know why that might be happening , is it possible it lacks permissions to execute
apk update
It shouldn't need permissions to execute apk update, and copa is able to patch the image locally and run cmd_test.go locally. Could we try running with --debug to see the full error output?
How do i run debug ? I'm unable to run it .
How do i run debug ? I'm unable to run it .
Debug is part of newRootCmd
rather than NewPatchCmd
since it is a root level flag for copa, which is why it is failing here. I think it would make sense for silent to be the same, can we move it to the newRootCmd()
function? We wouldn't be able to add test for this case in cmd_test.go, but it would make more sense to have it here.
Add option to silent the patch output by using --silent flag.
does not produce output except some end INFO.
Closes #643