search

project-dune / dune

MIT License
192 stars 61 forks source link

Dune and KASLR #4

Closed prekageo closed 7 years ago

prekageo commented 7 years ago

Dune causes a kernel panic on insmod on Ubuntu 16.04.2 LTS running Linux 4.8.0-51-generic. Apparently, the problem is KASLR and how Dune resolves symbols of the kernel at compile time. My fix so far is to add nokaslr in the kernel command line. What is your opinion on that? If you consider my approach appropriate, maybe we should add a note in the README about that.

kkaffes commented 7 years ago

I think your approach is valid. Do you want to make a pull request for the README change? I will merge it.

Also, did you see the issue that exists with Ubuntu 17.04? The declaration of VMX_EPT_EXTENT_INDIVIDUAL_ADDR was removed from kernel version 4.10 and according to the KVM commit history:

Bit 6 in EPT vmexit's exit qualification is not defined in SDM, so remove it.

It might make sense for us to remove it too but Ubuntu 17.04 is not LTS so my opinion is that we should not try to track every small change.

prekageo commented 7 years ago

Created pull request #5.

Off-topic: Regarding, the bit removed from Linux 4.10: This is a policy matter regarding what do you want to support. Since you are the official maintainer right now, the call is yours. I would vote to provide support for LTS but not newer. Of course, if somebody wants to commit a patch that fixes the problem without breaking LTS support, it will be very welcome.

kkaffes commented 7 years ago

Rebased and merged, thanks!

I agree with you regarding the LTS support. Closing the issue.