Fix twitter to broadcast deleted tweets to all clients - Githubissues

project-error / npwd

NPWD is a FiveM phone resource written entirely in TypeScript and React.

https://projecterror.dev

Other

351 stars 275 forks source link

Fix twitter to broadcast deleted tweets to all clients #1030

Closed BackSH00TER closed 1 year ago

BackSH00TER commented 1 year ago

Pull Request Description

Problem: If a player deletes a tweet, only that player will see the update in their twitter app, no other clients will receive the delete tweet event and will still be able to see the tweet.

Fix: When the player deletes a tweet, we will now broadcast the delete tweet event to all clients so that everyones UI reflects correctly.

Removed the call of deleteTweet() from ShowMore.tsx, as this was only handling it for the client that did the action and is now unnecessary as the deleteTweetBroadcast event will handle calling this for all clients.

Example: https://github.com/project-error/npwd/assets/18689469/ca9b28ba-e2e2-433b-9fa4-efc230fd6dac

Other player "The Man" deletes his tweets and you can see that they are removed from my UI
I delete some of my tweets and you can see they are removed from my UI

Pull Request Checklist:

[x] Have you followed the guidelines in our Contributing document and Code of Conduct?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Have you built and tested NPWD in-game after the relevant change?