fix(phone\common\hooks): correctly handle already loaded apps - Githubissues

project-error / npwd

NPWD is a FiveM phone resource written entirely in TypeScript and React.

https://projecterror.dev

Other

336 stars 277 forks source link

fix(phone\common\hooks): correctly handle already loaded apps #1148

Closed lukealford closed 2 months ago

lukealford commented 3 months ago

Pull Request Description

When having multiple external apps loaded, existing apps would vanish due to appAlreadyLoaded returning null and not the existing app config

Changes
Used nullish coalescence to determine if we require invoking generateAppConfig
Remove unnecessary conditionals
Updated existingApps type

Pull Request Checklist:

[x] Have you followed the guidelines in our Contributing document and Code of Conduct?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Have you built and tested NPWD in-game after the relevant change?

itschip commented 2 months ago

Thank you for the contribution!