project-ethea / Invasion_from_the_Unknown

Invasion from the Unknown, a Battle for Wesnoth add-on campaign.
Other
10 stars 4 forks source link

[S22B The Dark Hive] Mal Keshar/Elynia can attack with Union, even if either of them has already spent all moves/attacks #58

Closed Konrad22 closed 6 years ago

Konrad22 commented 6 years ago

Is that intended behavior? I can let Mal Keshar or Elynia attack normally and then let the other one follow up with an Union attack.

irydacea commented 6 years ago

Well...

https://github.com/project-ethea/Invasion_from_the_Unknown/blob/master/macros/union.cfg#L22

#
# General FIXME:
#
# Currently, it is possible for Elynia/Mal Keshar to use a non-Union attack
# first and let the other cast Union on an enemy before ending the current
# turn. This is because we can't currently filter on the assistant's
# attacks_left attribute, without using lua_function or [filter_wml] at least.
# Personally, I feel there's no need to fix this loophole, but I somehow
# suspect at least a dozen playtesters will report it as a bug anyway.
#
# Also, enemy Union casters (spoilers!) don't disable the player's ability to
# cast Union next turn. This is partly because the implementation would be too
# complicated (especially but not exclusively on 1.12.x without the 1.13.x
# [object] duration="turn end" attribute, but also because I'm not really sure
# it would make the gameplay more interesting as opposed to outright
# frustrating.
#
Konrad22 commented 6 years ago

Oops. You are good at guessing. xD