First cut of documents - Githubissues

project-eve / zenbuild

Linuxkit based IoT Edge Operating System (Zenix)

https://www.zededa.com

Apache License 2.0

14 stars 7 forks source link

First cut of documents #79

Closed deitch closed 5 years ago

deitch commented 5 years ago

As it says. Tried to capture the build process, with the intent of:

Making it easier for new people to understand
Find patterns to reduce redundancy and simplify
Find gaps with upstream tools, so we can remove our customizations where possible.

Still missing is a deep-dive into individual packages, especially ztools.

cc @eriknordmark @rvs @kalyan-nidumolu

deitch commented 5 years ago

Any chance @gianlzed @glguida wants to comment on the grub patches part? :-)

glguida commented 5 years ago

Sure, I’ll take a look! This was a long time ago and things have definitely changed — glad to see this project skyrocketing.

Expect something by EOD tomorrow!

deitch commented 5 years ago

Most kind of you. Feel free to comment/add on the section here ... or any other section, for that matter! :-)

rvs commented 5 years ago

Hey @gianlzed long time no see ;-) There's one gigantic patch that is the result of upstreaming CoreOS grub on top of latest GNU Grub 2.02. There's a few CoreOS patches and a few patches for things like propagating variables from submenus and little things like that

deitch commented 5 years ago

There's one gigantic patch that is the result of upstreaming CoreOS grub on top of latest GNU Grub 2.02.

@rvs , is it just a blind, "we like CoreOS's version but they don't maintain it"? Or do we know exactly what we want from that and why? And why is linuxefi removed afterwards?

I tried to capture most of it in the docs/.

deitch commented 5 years ago

Added docs/zedctr.md. Plane time can be useful, even when the Internet is down!

deitch commented 5 years ago

Urgh. I made all of the local links in the docs relative to the root, rather than to docs/. Will fix and push right now.

deitch commented 5 years ago

Added comments on generating the images/*.yml files from *.yml.in

deitch commented 5 years ago

Oh, I see @eriknordmark added more comments. Thank you. I will review later today.

rvs commented 5 years ago

Hey @deitch quick question -- when do you think you can take care of the outstanding feedback from @eriknordmark so we can finally merge this? Doesn't have to be perfect -- just to be the first step.

deitch commented 5 years ago

I got to most of them and pushed it out to the branch. Two of them are awaiting responses from him. With respect to zedctr I’m just going to scale down the part about modularization, since it remains a work in progress.

deitch commented 5 years ago

Two remaining comments for which I am awaiting feedback:

why we reboot (traveling; can speak Sunday or Monday)
ssh

rvs commented 5 years ago

@deitch I reviewed it once more and it looks definitely good enough to be merged. Still work to be done, but I hope we will start doing it very quickly, but incrementally.

I'm not a big fan of huge commits anyway -- so lets all pick a section that needs to be clarified and submit individual PRs for those.

In fact, I'm picking all of your remaining "Why?" questions and clarifying those in a separate PR.

deitch commented 5 years ago

I'm picking all of your remaining "Why?" questions and clarifying those in a separate PR

Excellent plan.