project-eve / zenbuild

Linuxkit based IoT Edge Operating System (Zenix)
https://www.zededa.com
Apache License 2.0
14 stars 7 forks source link

mkflash/make-raw needs to handle new dist #81

Closed eriknordmark closed 5 years ago

eriknordmark commented 5 years ago

@deitch I don't see to be able to add you as a reviewer.

deitch commented 5 years ago

I’m not a writer or admin of this repo. Can you add me @eriknordmark or @rvs ?

deitch commented 5 years ago

And thank you for catching it.

eriknordmark commented 5 years ago

@deitch I just realized there is also a symlink issue with fallback.img -> dist/amd64/fallback.qcow2, but too late for me to fix that tonight.

deitch commented 5 years ago

I just realized there is also a symlink issue with fallback.img -> dist/amd64/fallback.qcow2

I will get that right now.

deitch commented 5 years ago

Also, if you make me able to write or admin, I can do branches directly here.

deitch commented 5 years ago

See #82

rvs commented 5 years ago

@deitch we really don't want branched directly here

rvs commented 5 years ago

Hey @eriknordmark your change to mkimage-raw-efi broke the physical installer

I backed out your fix and testing a new one right now

deitch commented 5 years ago

I am happy to do on my own clone, it is fine. I suggested it because this PR is from simplify on local. I am happy either way.