search

project-eve / zenbuild

Linuxkit based IoT Edge Operating System (Zenix)
https://www.zededa.com
Apache License 2.0
14 stars 7 forks source link

Fix symlink #82

Closed deitch closed 5 years ago

deitch commented 5 years ago

Two things:

  1. Removes extra '|' that somehow made it into makefile (must have been my own copy-paste error).
  2. Fixes ln -s target to be just filename.
deitch commented 5 years ago

cc @eriknordmark @rvs

rvs commented 5 years ago

I have a different way of dealing with this which I just committed

deitch commented 5 years ago

No problem.

rvs commented 5 years ago

In general we should make sure we alway run make zenix before submitting PRs.

Actually, @deitch we should probably set the CircleCI job that tests that on all the incoming PRs. Do you think you can help with that?

deitch commented 5 years ago

In general we should make sure we alway run make zenix before submitting PRs.

I am not sure what needs to be done. It isn't in the docs I submitted because... I didn't know. :-)

we should probably set the CircleCI job that tests that on all the incoming PRs. Do you think you can help with that?

Yes, if someone will write up what it is. I won't get to it until the weekend. All day flight ahead of me.

rvs commented 5 years ago

@deitch it literally is the following command: make pkgs zenix

if it passes -- we will flag PR as mergable