Integrate the new scons-based support for Spartan

project-everest / everest-ci

CI scripts for project everest

3 stars 8 forks source link

Integrate the new scons-based support for Spartan #21

Closed msprotz closed 7 years ago

msprotz commented 7 years ago

Several sub-tasks:

[x] add Python2.7 in the Windows build environment and in the Linux one. Note: we most likely want the native Windows Python, not the Cygwin one.
[x] adapt the everest script to check for Python (non-Windows), and check for Python
[x] and offer to install it (Windows)
[x] adapt the everest script to change the CMD invocation for Spartan at https://github.com/project-everest/everest/blob/master/everest#L522 with the one that will trigger Scons from a Native x64 VS Tools Prompt (the one that the Spartan folks are using) possibly skipping scons.bat since it's a one-liner after all
[x] test the whole setup using the ubuntu-from-scratch scenario (depends on Spartan moving to GitHub first)
[x] if Spartan drops Scons from their source tree, need to install scons on the windows machine too -- need to make the script download & launch the scons installer in quiet mode, or something similar (see http://scons.org/pages/download.html)

CC @barrybo

msprotz commented 7 years ago

My commit https://github.com/project-everest/everest/commit/8cd00479e82bcff5f6db34d9cea25072f9ba47f0 fixes "adapt the everest script to check" and "change the CMD invocation"
My commit https://github.com/project-everest/everest-ci/commit/d0ff7e6b9c54713ed7a74b8d8fc1e758ae0ea021 adds scons into the Linux build environment
Darren ran the Python installer on the CI machine

vkanne-msft commented 7 years ago

Waiting on VALE move to github

vkanne-msft commented 7 years ago

Vale is now on GitHub. Can we update our scripts to use the GitHub repo?

darrenge commented 7 years ago

I would think so ... first thing is to get "green" in all our existing tests.

BarryBo commented 7 years ago

I successfully cloned and built using the instructions on the project homepage (set up fslexyacc/python27/scons and used my VS2015 tools). I built Windows 32-bit x86 only.

BarryBo commented 7 years ago

... and scons... the gzip tarball works on Windows. There is no need to use the Windows Installer .exe to install it.

msprotz commented 7 years ago

https://github.com/project-everest/everest/tree/vale is a first attempt at this -- happy for anyone to pick it up and/or merge into master

as far as I know the everest build & test has been green for the past few builds

sishtiaq commented 7 years ago

@darrenge Done? Can we close this?

darrenge commented 7 years ago

I am not sure where we are at with this one.

msprotz commented 7 years ago

I checked a couple checkboxes -- ideally it'd be nice if the Everest script offered to install scons on Windows via the msi

sishtiaq commented 7 years ago

Ah, I see. I didn't see that unticked box.

darrenge commented 7 years ago

Looking into getting Python installed and scons.bat installed automatically.

darrenge commented 7 years ago

Put in a pull request to install Python 2.7 and Scons on the Windows side of things if they are not already installed. Once that merges, then this issue can be closed.

msprotz commented 7 years ago

Closed via https://github.com/project-everest/everest/pull/30 -- thanks much!