search

project-everest / everest-ci

CI scripts for project everest
3 stars 8 forks source link

Fix the logging of test runs so properly describing log #82

Closed darrenge closed 7 years ago

darrenge commented 7 years ago

mitl-nightly has logs labeled mitls-ci

hacl star nightly has logs labeled hacl-ci

darrenge commented 7 years ago

Looking at this some more ... if we change this, we lose all the historical aspect from the dashboard. The file name isn't that critical anyways as no one would realistically go look at CI-LOGS repo. The main thing is that the dashboard goes to the proper file and shows the proper logs.

msprotz commented 7 years ago

There is a risk of collision when the nightly and the ci run try to write to the same log file, I think. Using distinct "stems" guarantees that if two runs happen at the same time on the same commit, they'll still touch different filenames.

darrenge commented 7 years ago

Hmmm .. guess we should fix them then.

msprotz commented 7 years ago

ok I double-checked and they have the VSTS build number in them already, so this should be enough to disambiguate, right? we do know that VSTS won't assign the same build number twice?

darrenge commented 7 years ago

Right ... build number should just be incremental. Build number will make it unique enough.

darrenge commented 7 years ago

i think we just keep it the way it is which will keep the history etc. Once again ... closing this out.