project-everest / mitls-fstar

Verified implementation of TLS 1.3 in F*
https://www.mitls.org
Other
173 stars 16 forks source link

miTLS server responds to bad_certificate alert with encrypted alert of decryption_failed_RESERVED #177

Open oweisse-msft opened 7 years ago

oweisse-msft commented 7 years ago

See also https://github.com/mitls/mitls-fstar/issues/176.

Is decryption_failed_RESERVED the right response to another alert?

beurdouche commented 7 years ago

Not if you are using TLS 1.3.

s-zanella commented 7 years ago

This is another case where the server expects an encrypted message but gets a plaintext alert. A decryption_failed_RESERVED alert must never be sent in TLS 1.3 (we could send decrypt_error instead), but really the server should parse and respond to plaintext alerts before receiving the client's Finished message.

BarryBo commented 6 years ago

Can you follow up on this, to make sure it is addressed during verification? If it is truly a bug in the TLS 1.3 codepath.