project-everest / mitls-fstar

Verified implementation of TLS 1.3 in F*
https://www.mitls.org
Other
173 stars 16 forks source link

Fixes for link issues on Linux in the quic2 branch #196

Closed BarryBo closed 6 years ago

BarryBo commented 6 years ago

I hit a number of issues linking and using .so files on Bash for Windows running Ubuntu.

I confirmed that these changes still work on Cygwin.

EDIT: Sigh. No, the mingw linker doesn't like the -z switch after all. I missed the error when I built on Cygwin. Will refactor it out into a !Cygwin path.

EDIT: Neither Cygwin nor OS/X versions of ld support -z, so I made the change Linux-specific.

wintersteiger commented 6 years ago

Wow, that looks like a lot of trouble. mitls.exe built just fine on my WSL (my main environment these days), so I'm surprised you needed to make changes to libmipki. We may be using different version of gcc or similar.

msprotz commented 6 years ago

Looks good to me except for the bit about the space variable which I don't understand either.