bool expression || and &&

[lixingwang]

Current behavior (how does the issue manifest):

Here are 2 examples regarding && and ||

• $activity[GetByCompositeKey].code == 200 && $activity[GetByCompositeKey].result[0].key != $flow.agreement.AgreementID
• $activity[GetByCompositeKey].code == 400 || $activity[GetByCompositeKey].code == 400

Today we are going to evaluate both the right and left sides. but we don't need to

• If left expression is false and we don't need to evaluate the right expression for &&
• We don't need evaluate the right expression if the left expression is true for ||

Expected behavior:

• If left expression is false and we don't need to evaluate the right expression for &&
• We don't need evaluate the right expression if the left expression is true for ||

Minimal steps to reproduce the problem (not required if feature enhancement):

Please tell us about your environment (Operating system, docker version, browser & web ui version, etc):

Flogo version (CLI & contrib/lib. If unknown, leave empty or state unknown): 0.X.X

Additional information you deem important (e.g. issue happens only occasionally):

[lixingwang]

Fixed at PR https://github.com/project-flogo/core/pull/195