project-flogo / flogo-web

Project Flogo Web UI
http://flogo.io
BSD 3-Clause "New" or "Revised" License
65 stars 36 forks source link

Undesired dot in mappings #1263

Closed fcastill closed 4 years ago

fcastill commented 4 years ago

Environment

How are you running Flogo Web?

Describe the bug

In the mapper if I click the name of an activity or trigger in the available data pile then the expression is generated with an additional dot.

To Reproduce

Steps to reproduce the behavior:

  1. Create a flow where an activity (say activity A) has at least one activity prior to it that has outputs (activity B) and open the input mappings config for Activity B
  2. In the mapper config, under "Available data" click activity's A name (not a property inside the activity's A tree)
  3. Observer the generated mapping has a dot (.) at the end of the expression

Expected behavior

Not clear, we need to think:

  1. Should the dot be omitted?
  2. Can activities be referenced without accessing one of their properties? If not then maybe the activity name should not be clickable? (consider there will be cases where the entry will not belong to an activity and then the name might need to be clickable)
  3. Is it an actual error? When the name is clicked the editor gains focus and the user can type, the editor also shows an error which should indicate that more actions need to be taken. Perhaps we just need a more clear indication that the user needs to type more.

Screenshots

Screen Shot 2019-12-10 at 7 03 13 PM