project-flogo / flogo-web

Project Flogo Web UI
http://flogo.io
BSD 3-Clause "New" or "Revised" License
63 stars 36 forks source link

Cannot import github.com/project-flogo/core/app/propertyresolver #1306

Open reidlai opened 4 years ago

reidlai commented 4 years ago

Environment

How are you running Flogo Web?

Describe the bug

Web UI keeps on to complain error when install github.com/project-flogo/core/app/propertyresolver

To Reproduce

Steps to reproduce the behavior:

  1. Click install plugin in UI
  2. Enter github.com/project-flogo/core/app/propertyresolver
  3. Click Install Button
  4. See error in Web

Expected behavior

Should see plugin installed in web UI

Additional context

When we set trigger settings, flogo runtime cannot resolve env and property except we install github.com/project-flogo/core/app/propertyresolver in app flogo.json. When compiling using flogo command line CLI it works perfect. But I got error when I want to import flogo.json in WebUI.

fcastill commented 4 years ago

This is similar to https://github.com/project-flogo/flogo-web/issues/1151 and the reason for both is that currently the UI can only handle contributions with a descriptor.json and cannot handle other types of imports.

There are many things in the UI client and server that depend on the existence of the descriptor.json, like validating that the contribution/package is installed in the engine, creation and modifications of instances of activities and triggers, compiling, exporting, aliasing, and I think more.

Because of that we're yet to figure out a way to allow importing and handling non-contribution packages in a general way. But I guess we could look into adding an exception in the validation process for github.com/project-flogo/core/app/propertyresolver if that's something that we expect to be often used.

Thoughts @mellistibco ?

mellistibco commented 4 years ago

Hmm, yeah, perhaps we need to look at providing a descriptor.json for all contribs, which would enable them to be installed via the UI. Another option, specifically for the default property resolvers would be to add the imports into the default main.go, @fm-tibco thoughts?

mellistibco commented 4 years ago

It seems that the default property resolvers are loaded by the engine and don’t need a specific import via the UI, however that was just added a few commits ago and the current build of web UI wouldn’t reflect that until the next release.

That still leaves the pending issues/question with regards to other property resolvers that may need to be imported via the UI. We should definitely enhance the UI to support this scenario.