project-flogo / rules

Golang based Rules for Real-time Contextual Decisions
BSD 3-Clause "New" or "Revised" License
112 stars 39 forks source link

Add Kafka trigger example #65

Closed rameshpolishetti closed 5 years ago

rameshpolishetti commented 5 years ago

Current behavior: Currently, we have only rest trigger based examples

Expected behavior: Add kafka trigger based example, describing how a Kafka message can be input source to rule action & how kafka topic and messages are mapped to tuple type and data.

mellistibco commented 5 years ago

I don't understand this enhancement request. Flogo Rules should support any Flogo trigger. Why are we suggesting to implement the exact the same thing already implemented in flogo core? If someone wants to trigger a flogo rules app from any source, they should be using flogo rules as an action in a flogo application and hence get the ability to trigger the rules via any available trigger in the flogo ecosystem.

rameshpolishetti commented 5 years ago

@mellistibco It's my bad. I didn't mean to add same Kafka trigger here instead add an example for kafka channel and update rules/action input parameters (for mapping, only if required). Let me update the issue title/description accordingly.

mellistibco commented 5 years ago

i think we need to clean up terminology also. we need to keep things consistent. A channel is basically the same thing as a trigger, can we work on cleaning up terminology both in code and in documentation? I can't think of any reason to have multiple overlapping terms. Flogo has standardized on triggers and we should stick with that as a way to define/describe an input source into an action.

rameshpolishetti commented 5 years ago

@mellistibco agreed, updating the issue terminology accordingly. Don't want to dilute the original objective of this issue. Can we take up fixing any terminology deviations as a different issue?

mellistibco commented 5 years ago

@rameshpolishetti yes, let's create a different issue to capture and track the larger task of fixing terminology, etc.