project-gemmi / gemmi

macromolecular crystallography library and utilities
https://project-gemmi.github.io/
Mozilla Public License 2.0
205 stars 42 forks source link

The defining of preprocessor CHECK collides with unit test software #273

Closed rimmartin closed 1 year ago

rimmartin commented 1 year ago

Hi,

The defining of CHECK in pdb.hpp collides with doctests unit test framework.

Okay to change this pdb.hpp CHECK to GEMMI_CHECK ?

rimmartin commented 1 year ago

hmm, there is an undefine later in pdb.hpp. Let me search some more

rimmartin commented 1 year ago

ah, the undef is clearing so the doctests CHECK gets undefined