search

project-gen3sis / R-package

Repository of the R-packageGen3sis
https://project-gen3sis.github.io/R-package/
GNU General Public License v3.0
29 stars 9 forks source link

implement CI #49

Open ohagen opened 3 years ago

ohagen commented 3 years ago

previously relying on Travis, now we need another solution. Specially if we want to improve collaboration

richelbilderbeek commented 3 years ago

Great idea! If you want, I volunteer to add a GitHub Actions script by Pull Request to do the same things as the Travis CI one. I have much experience with both CI's, so that would be easy. Also, Gen3sis seems awesome to me!

florianhartig commented 3 years ago

Hi Oskar, for me Travis CI still works without charge when switching to .com, despite their announcement that you have only 100h or so free.

We have switched a part to GH actions though, have a look at https://github.com/TheoreticalEcology/s-jSDM/tree/master/.github, for example.

ohagen commented 3 years ago

Hi @richelbilderbeek and welcome! So nice to see you here! This would be really great.. feel free to pick a solution that you think works the best. @florianhartig thanks for the info.

richelbilderbeek commented 3 years ago

@ohagen awesome! I created Pull Request #51 to fix this Issue :-)

ohagen commented 3 years ago

Thanks @richelbilderbeek! I see that you submitted to the main branch and we plan for now on to work on the development branch. Not sure if you can easily submit to this other branch? Since @benj919 work on the CI, can you Beji check is this in accordance and accept the merge? Thanks again @richelbilderbeek

richelbilderbeek commented 3 years ago

Hi @ohagen, you are right, silly me, I should have worked on develop. I will close this PR and create a new one on develop today :-)

florianhartig commented 3 years ago

fwiw, from my perspective it would be most sensible to push this into the main branch and then update to the other branches. There is no reason that this shouldn't go into main directly, as this should also be tested. This will not be exported with the package, it's just the test.

florianhartig commented 3 years ago

Probably it doesn't matter though. I just don't know if the main branch will be tested as long as there is no action folder present.

florianhartig commented 3 years ago

I think it might even be necessary to have a new workflow in the main branch, see https://github.community/t/workflow-files-only-picked-up-from-master/16129

richelbilderbeek commented 3 years ago

The main folder will be tested directly at acceptance. Adding a build badge to show off the build status can be added to develop first :-)

benj919 commented 3 years ago

Welcome @richelbilderbeek and thank you for that workflow. I haven't worked with github actions yet, though your pull request looks good on a first glance (If limited to Macos runs if I interpret that correctly ;) ).

@ohagen @florianhartig If I understood the travis changes correctly they were not applied equally to all repos: as an open source and/or academic project it should be possible for us do "just" request more free credits from them either manually or semi regularly. They cut off the unlimited free for all after some crypto-mining related abuse. I personally have no preference to either travis or github actions, though I like the github actions setup with the full actions code under git in one place.

Does anyone know the pricing/allowances/conditions on using github actions?

richelbilderbeek commented 3 years ago

I haven't worked with github actions yet, though your pull request looks good on a first glance (If limited to Macos runs if I interpret that correctly ;) ).

Notice how little I did: one R command, then adding one markdown, to DESCRIPTION :-) . Personally, I always use simpler ones, but I think these are just as good.

@benj919 I know Travis CI hands out free credits, but they are slow -think months!- to respond, and this only includes repos I have had a response from; there are still some of mine pending.

GitHub Actions is free for public repos. If you pay for GitHub (i.e. you are a GitHub Pro user), GHA also works on your private repos.

florianhartig commented 3 years ago

Hi @benj919

a) true, we could / should add Ubuntu as well, I think Windows is also possible. We can do this once the PR is merged though.

b) about Travis: as I said, I migrated https://github.com/florianhartig/DHARMa from travis.org to travis.com because the org builds didn't run properly any more. I expected this would run out after this free hours, but afaiks, those hours were never counted, my builts just continue to run!

Side comment: if possible, I would let Travis and GH actions run side by side, also because my experience is that they test slightly different, so it's a good check.

benj919 commented 3 years ago

I merged the pull request, let's see if this works out. I also reopened the issue to keep track of the next steps.

Notice how little I did: one R command, then adding one markdown, to DESCRIPTION :-) . Personally, I always use simpler ones, but I think these are just as good.

Sure, but even if it's a single line and the github actions being copied over from R somewhere it saves me/us half a day of investigating this stuff myself ;)

@florianhartig sure, running them side by side is an option as well

ohagen commented 3 years ago

thanks a lot folks! Its beautiful to see this moving forward.

ohagen commented 2 years ago

Currently we have both workflows working.

Latest results are called by the README file from the latest yaml pages. 

DEVELOPMENT [![R-CMD-check](https://github.com/project-gen3sis/R-package/actions/workflows/R-CMD-check.yaml/badge.svg?branch=development)](https://github.com/project-gen3sis/R-package/actions/workflows/R-CMD-check.yaml)

MASTER [![R-CMD-check](https://github.com/project-gen3sis/R-package/actions/workflows/R-CMD-check.yaml/badge.svg?branch=master)](https://github.com/project-gen3sis/R-package/actions/workflows/R-CMD-check.yaml)

still open is adding windows and linux .yaml checks