Closed richelbilderbeek closed 3 years ago
I should have worked on develop. I will close this PR and create a new fresh one :-)
Reopened as @florianhartig thinks that pushing to main is fine. I agree with his line of reasoning.
Note that having a CONTRIBUTING.md file would have taught me to push to develop.
Looks fine to me! Good idea with the contributing.md!
Many thanks, Richel!
@florianhartig thanks so much for accepting that help, from my experience, that is quite rare!
@florianhartig are we good to merge this? This is just a friendly reminder: sometimes I forget to push the big green 'Merge' button myself as well :-)
I wanted to let @benj919 or @ohagen merge, I just gave my opinion that it looks good to me!
Here it is: a Pull Request to add GitHub Actions CI to this repo, which fixes #49 .
You can see the run pass at here. After acceptance of this PR, you can find results here, at the Actions tab.
This is all I did:
usethis::use_github_actions
, output with harmless warnings below.markdown
as aSuggest
ed package inDESCRIPTION
. This is needed nowadays when using vignettes