project-husky / husky

Health Usability Key
https://project-husky.github.io/husky/
Eclipse Public License 1.0
17 stars 8 forks source link

CH-EMED-EPR: ChEmedEprDosage::getInclusiveEndTime fails when period has end #73

Closed dvribeira closed 1 year ago

dvribeira commented 1 year ago

Hl7Dtm.fromHl7 fails complaining about the format not being compliant

dvribeira commented 1 year ago

For instance, an end datetime in boundsPeriod specified as "end": "2024-02-21T22:59:59Z" triggers the issue.

qligier commented 1 year ago

It seems Husky needs a proper FhirDateTime class, built like Hl7Dtm. The Z timezone is not supported in HL7 DTM, and colons neither. The other way would be to perform string substitution before parsing as a DTM. With a proper test case it could be sufficient.

On Mon Aug 21 16:03:43 GMT+02:00 2023, dvribeira @.***> wrote:

 For instance, an end datetime in boundsPeriod specified as "end":  "2024-02-21T22:59:59Z" triggers the issue.    —  Reply to this email directly, view it on GitHub  [https://github.com/project-husky/husky/issues/73#issuecomment-1686397146],  or unsubscribe  [https://github.com/notifications/unsubscribe-auth/AAZFQRYXTI4VAX34ZLB6H73XWNTD7ANCNFSM6AAAAAA3YNY6FE].  You are receiving this because you are subscribed to this  thread.Message ID: @.***>