project-icp / bee-pollinator-app

The web application front end for the ICP Pollinator Decision Support Tool 🐝
Apache License 2.0
6 stars 1 forks source link

Overlap spinner to entire apiary card #413

Closed fungjj92 closed 5 years ago

fungjj92 commented 5 years ago

Overview

The spinners when apiary cards loaded covered only the scores, and were displayed absolute to the page, not the card. Therefore, when the card list grew long and scrollable, spinners would float in space over the list.

This card fixes the spinners and fixes them over the entire card, not just the scores -- this has the benefit of not showing the apiary name until it is successfully reverse geocoded.

I gave cards a minimum height of 80px, which is roughly their height already when loaded with info.

Connects #392

Demo

screen shot 2019-01-09 at 5 30 18 pm

Testing Instructions

Click the map, add an apiary. Toggle the buffer. Add enough apiaries so the list scrolls. Spinners should act as you expect.

rajadain commented 5 years ago

Taking a look now

fungjj92 commented 5 years ago

Thanks for review!