search

project-icp / bee-pollinator-app

The web application front end for the ICP Pollinator Decision Support Tool 🐝
Apache License 2.0
6 stars 1 forks source link

Bugfix: unify on map center format #549

Closed fungjj92 closed 4 years ago

fungjj92 commented 4 years ago

Overview

Fix geocoder searches panning & zooming the map. This bug was introduced by formatting coordinate information as an array instead of an object 😱

Also, I removed the beekeepers prototype because we don't need that anymore and it's generating dependabot PRs.

Refs #548

Demo

bees

Testing Instructions

Use the geocoder and see that selecting a location pans & zooms the map as many times as you select new locations. See no weird behavior clicking apiary card markers to pan & zoom to their locations.

rajadain commented 4 years ago

Taking a look now

rajadain commented 4 years ago

+1 tested, this is working correctly. However, this is too big a change for a hotfix. We should separate this into two PRs:

  1. A branch off develop that targets develop which removes the prototype
  2. A branch off master that targets hotfix/1.4.1 which fixes the map zoom
fungjj92 commented 4 years ago

Thanks for taking a look. Can do.