project-koku / curator-operator

Go Operator for OpenShift metrics
5 stars 11 forks source link

Add support for watching the CronJob resource in the fetchdata-operator #17

Closed timflannagan closed 1 year ago

timflannagan commented 2 years ago

Goal: Update the fetchdata-operator and add a Watches for the CronJob resource, as the fetchdata-operator essentially wraps a CronJob resource to handle the user-provided scheduling.

For a concrete reference: https://github.com/operator-framework/rukpak/blob/bb79ed5efd7e7c7a9c8ff5c83fdb10697ecee2a5/internal/provisioner/plain/controllers/bundleinstance_controller.go#L349

AC:

skanthed commented 2 years ago

This task is done. Waiting for report-controller PR to be merged and will create PR for this.

sesheta commented 2 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

sesheta commented 2 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

sesheta commented 1 year ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

sesheta commented 1 year ago

@sesheta: Closing this issue.

In response to [this](https://github.com/operate-first/curator-operator/issues/17#issuecomment-1288877516): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.