Introduce a happy path e2e test case for the fetchdata-operator

project-koku / curator-operator

Go Operator for OpenShift metrics

5 stars 11 forks source link

Introduce a happy path e2e test case for the fetchdata-operator #19

Closed timflannagan closed 1 year ago

timflannagan commented 2 years ago

Goal: introduce a happy path e2e test case for the recently introduced fetchdata-operator (#13) that gives us some confidence we're not regressing on this functionality on a per-PR-basis while we iterate on this operator-based curator implementation.

AC:

Introduce ginkgo as a tools.go dependency
Add a simple e2e test using ginkgo that instantiates an individual FetchData custom resource, and ensure that the underlying configures results in a CronJob resource being created with the correct Job template.

timflannagan commented 2 years ago

This ticket is potentially a bit more nuanced then I had originally imagined. We absolutely need a simply e2e test case that handles the happy path for this recently introduced fetchdata-operator but the overall effort around testing this functionality could prove to be more than one person can chew. As usual, feel free to ping me in slack if you have any questions.

sesheta commented 2 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

sesheta commented 2 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

sesheta commented 1 year ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

sesheta commented 1 year ago

@sesheta: Closing this issue.

In response to [this](https://github.com/operate-first/curator-operator/issues/19#issuecomment-1288191370): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.