Closed dccurtis closed 5 years ago
:exclamation: No coverage uploaded for pull request base (
master@fd3c521
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #463 +/- ##
========================================
Coverage ? 97.7%
========================================
Files ? 67
Lines ? 3742
Branches ? 393
========================================
Hits ? 3657
Misses ? 50
Partials ? 35
Impacted Files | Coverage Δ | |
---|---|---|
masu/external/kafka_msg_handler.py | 100% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update fd3c521...71ebb2c. Read the comment docs.
Hitting a bad intermittent failure in test_populate_ocp_on_aws_cost_daily_summary
. Will fix in a separate PR, but will probably continue to hit re-test for now to get this in :)
Addresses #462
The asyncio method
run_in_executor
should be ran in a try/catch block so that any exceptions that are thrown unblocks the event loop.Testing
setup_complete
from theProvider
model was easy to do.Test Results 1. Koku Change
2. Upload nice generated payload to upload service two times.