the exact package pins in the actual package limit use in other ecosystems

project-koku / nise

A tool for generating sample cost usage data for testing purposes

GNU Affero General Public License v3.0

9 stars 15 forks source link

the exact package pins in the actual package limit use in other ecosystems #179

Closed RonnyPfannschmidt closed 4 years ago

RonnyPfannschmidt commented 4 years ago

without context, the pins in setup.py seem needlessly exact, this creates issues when trying to use the package in the insights testing ecosystem as it hampers our ability to pin dependencies (pypa/pip#988 applies)

https://github.com/project-koku/nise/blob/b5a0c65305c1ca8c443b6f116966b704649a91f1/setup.py#L23-L69

i'm happy to provide a patch weakening them once its understood why it was pinned so tightly

blentz commented 4 years ago

@RonnyPfannschmidt - We don't have a strong need for such exact requirements. I think the main reason they're like that is because we use PyUp.io to help us stay up-to-date, and PyUp.io automagically bumps those versions with each of its PRs.

A patch to open them up to at least minor version updates (e.g. "azure-common~=1.1") would be welcome.

blentz commented 4 years ago

This has been fixed in PR #181 .