search

project-koku / nise

A tool for generating sample cost usage data for testing purposes
GNU Affero General Public License v3.0
9 stars 15 forks source link

GCP generator currency bug fix #388

Closed shannon-donahue closed 2 years ago

shannon-donahue commented 2 years ago

There was a small bug where the network GCP generator was not overriding the default USD value and getting foreign currency code

Testing Instructions

  1. Pull Branch
  2. pipenv in to nise
  3. Run make install to make sure your environment is up to date with the new code
  4. Run the following command 
    nise report -c jpy gcp --static-report-file "Local file path"/nise/example_gcp_static_data.yml --gcp-report-prefix report-name --gcp-bucket-name ./

    5.There should be a new directory under nise which contains a file report-name.csv Open this file and just insure the currency column only contains JPY for the entire file

codecov[bot] commented 2 years ago

Codecov Report

Merging #388 (ea25a1f) into main (9039ec6) will increase coverage by 0.1%. The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main    #388     +/-   ##
=======================================
+ Coverage   93.2%   93.2%   +0.1%     
=======================================
  Files         50      50             
  Lines       3937    3937             
  Branches     550     550             
=======================================
+ Hits        3669    3671      +2     
+ Misses       152     151      -1     
+ Partials     116     115      -1