project-koku / nise

A tool for generating sample cost usage data for testing purposes
GNU Affero General Public License v3.0
9 stars 15 forks source link

Plopezpe/add static subscription name #459

Closed pedrolp85 closed 1 year ago

pedrolp85 commented 1 year ago

This PR adds support to create an Azure report (--version-two) with an static subscription_name

To test this:

add the subscription name key to an Azure yml static file:

# SubscriptionGuid
accounts:
  payer: 38f1d748-3ac7-4b7f-a5ae-8b5ff16db82d
  subscription_name: 'azure_multi_source0 subs name'
  user:
    - 38f1d748-3ac7-4b7f-a5ae-8b5ff16db82d
  currency_code: USD

And run: nise -lll report azure --azure-container-name dest_directory_for_report --azure-report-name costnise04 --static-report-file static_file_with_subs_name.yml --version-two

pedrolp85 commented 1 year ago

Not really sure why this unit tests are blowing up

codecov[bot] commented 1 year ago

Codecov Report

Merging #459 (e5a264f) into main (7bd91d3) will increase coverage by 0.2%. The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main    #459     +/-   ##
=======================================
+ Coverage   93.4%   93.6%   +0.2%     
=======================================
  Files         60      60             
  Lines       4576    4577      +1     
  Branches     653     653             
=======================================
+ Hits        4276    4284      +8     
+ Misses       161     154      -7     
  Partials     139     139             
pedrolp85 commented 1 year ago

Modified a test to cover code block nise/report.py 364-372

pedrolp85 commented 1 year ago

Can we just bump the nise version please :)

bumped, thanks for the review