Closed maskarb closed 11 months ago
Merging #466 (ae0a9fa) into main (33e2786) will increase coverage by
0.0%
. The diff coverage is100.0%
.
@@ Coverage Diff @@
## main #466 +/- ##
=====================================
Coverage 93.6% 93.6%
=====================================
Files 60 60
Lines 4587 4603 +16
Branches 657 660 +3
=====================================
+ Hits 4292 4307 +15
Misses 155 155
- Partials 140 141 +1
followed testing instructions and looks good to me:
One other error to watch out for is: The specified bucket does not exist
NoSuchBucket
Summary
Adds 2 new CLI args for OCP report generation:
--minio-upload
: the url to minioS3_ACCESS_KEY
,S3_SECRET_KEY
,S3_BUCKET_NAME
env variables must be set. These are the credentials to access minio and the bucket in minio where the payload will be sent.--payload-name
: a static name for the payload uploaded to minio. if not provided, the payload name will start with the assembly-id of the payload manifest.{payload-name}.{YYYY_MM}.tar.gz
.Testing:
with
--payload-name
without
--payload-name
some error pathways:
nise: error: --minio-upload http://localhost:9000 was supplied as an argument but the environment must have S3_ACCESS_KEY and S3_SECRET_KEY and S3_BUCKET_NAME defined when attempting an upload to Minio (or S3).
$ S3_ACCESS_KEY="kokuminioaccess" S3_SECRET_KEY="kokuminiosecret" S3_BUCKET_NAME="ocp-ingress" nise -lll report ocp -s 2023-10-01 --ocp-cluster-id test-001 --daily-reports --payload-name my-payload-name
nise: error: --payload-name is only used with --minio-upload