project-koku / nise

A tool for generating sample cost usage data for testing purposes
GNU Affero General Public License v3.0
9 stars 15 forks source link

[COST-4745] Update compute engine SKUs for networking #508

Closed cgoodfred closed 4 months ago

cgoodfred commented 4 months ago

The networking SKU's have changed to be consistent on wording with Data Transfer In or Data Transfer Out

Relevant GCP announcement: https://cloud.google.com/data-transfer/product-name-change-announce SKU Verification: https://cloud.google.com/skus?hl=en&filter=Network%20VPN%20Intra%20Region%20Data%20Transfer&currency=USD

Testing: Create a yaml that specifies a compute engine resource with any of the SKUs and see that all the values generated have the correct SKU Description.

Example generator:

  - ComputeEngineGenerator:
      start_date: last_month
      price: 20
      usage.amount_in_pricing_units: 500
      sku_id: 6B8F-E63D-832B 
      instance_type: n1-standard-4
      location.region: us-west1-a
      resource.name: projects/my_fake_project/instances/gcp_compute1
      resource.global_name: //compute.googleapis.com/projects/my_ffake_project/zones/australia-southeast1-a/instances/big_fake
codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.7%. Comparing base (0b88a23) to head (326c08c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #508 +/- ## ===================================== Coverage 93.7% 93.7% ===================================== Files 62 62 Lines 4677 4677 Branches 658 658 ===================================== Hits 4383 4383 Misses 154 154 Partials 140 140 ```