search

project-lux / data-pipeline

Data pipeline to harvest, transform, reconcile, enrich and export Linked Art data for LUX (or other system)
Apache License 2.0
18 stars 1 forks source link

bug didn't create work or object in influenced triples #152

Closed kkdavis14 closed 3 weeks ago

kkdavis14 commented 1 month ago

caused creation of this triple "https://lux.collections.yale.edu/ns/linguisticobjectInfluencedCreation"

See https://github.com/project-lux/lux-marklogic/issues/357

azaroth42 commented 3 weeks ago

typ.lower() still needs to be called to turn Place in to place

azaroth42 commented 3 weeks ago

Revised plan -- extract the pfx assigner at line 174-200 into a new function and then use the result whenever we need the "prefix" for LUX

kkdavis14 commented 3 weeks ago

@azaroth42 PR is ready for re-review

azaroth42 commented 3 weeks ago

Also needs to call the new function for the referenced records :)

kkdavis14 commented 3 weeks ago

@azaroth42 it calls it at line 183--is that not sufficient? it seems like pfx is only the record we're on/only one at a time and doesn't need created multiple times.

azaroth42 commented 3 weeks ago

Also circa 280 and 320 to avoid calculating typ in different ways

kkdavis14 commented 3 weeks ago

@azaroth42 oh yeah for the actual reason of this ticket :D also added it in a few other places typ was being created.

azaroth42 commented 3 weeks ago

Perfect, thank you!