search

project-lux / lux-frontend

Web front end of LUX
Apache License 2.0
3 stars 0 forks source link

People: Related Events (from 440) #10

Open gigamorph opened 4 months ago

gigamorph commented 4 months ago

Problem Description: The person page does not show events related to a person or group.

Expected Behavior/Solution: Add 2 new Related List accordions for events on people/group pages to match the corrected mockup templates (added 3/11/24).

  1. Events Carried Out By (only on group pages)
  2. Events Containing Objects Created By (only on people pages)

Requirements:

Needed for promotion: If an item on the list is not needed, it should be crossed off but not removed.

UAT/LUX Examples:

Dependencies/Blocks:

Related Github Issues: N/A

Related links:

Wireframe/Mock for Related List

Image

prowns commented 4 months ago

Per UAT - needs to be formatted as a Related List; should show number of results. What happens when there are other sorts of events (people/events relationships) to show.

Approved by UAT, but Keep ticket open - revise for next milestone. Should look like mockup on #440. @miketullo95 <-- can you look at this and update the mockup here.

@ar2674 - after this deployment cycle is complete, let's move this to the next milestone and get UAT to review updated mockup.

kamerynB commented 4 months ago

@prowns Can this please be reviewed again? After the discussion in the team meeting, there needs to be clear indication what the relationships are within ML and what the HAL link will be in the middle tier.

cc: @clarkepeterf

kamerynB commented 4 months ago

After further discussion, the Events Containing Objects Created By does not have the correct query and the HAL link should be updated in the middletier once the correct query is determined. The Events Carried Out By list is correct as it is currently.

This should not require a frontend change but this issue should remain open until the HAL link is fixed.

cc: @prowns @clarkepeterf

clarkepeterf commented 3 months ago

Note from 4/12 on ML issue: Can't do for this release - Events are related through Sets, which we can't use for frontend search links. Need to tweak Related List code to convert to an Objects/Works search.

kamerynB commented 2 months ago

Move to the 5/13 milestone once milestone is created.

roamye commented 3 weeks ago

@kamerynB - Missing the 'By' in the Events Carried Out By accordion. It currently only says Events Carried Out in the accordion for tst.

hot fix?

Also from ur comment on March 13th - does that mean the accordions should not look as related lists? (they currently do not, but I wanted to verify the reason is because of the comment on 3/13)

kamerynB commented 3 weeks ago

@roamye This wasn't part of the deployment.

roamye commented 3 weeks ago

@kamerynB - what wasn't part of the deployment? The Events Carried Out? the related lists or both?

Should this not be a part of this milestone since ML11 does not have a milestone?

kamerynB commented 3 weeks ago

@roamye None of it. It was deployed a while ago but requires more work. I believe the decision was that the two lists would be combined into one and shown as a related list, as expressed in the wireframe.

Note: this discussion was continued in Teams.

roamye commented 11 hours ago

Since UAT is earlier next week this issue may be pushed to the next milestone. TBD by @clarkepeterf and @kamerynB