project-lux / lux-frontend

Web front end of LUX
Apache License 2.0
3 stars 0 forks source link

Research dataset changes #146

Open kamerynB opened 3 months ago

kamerynB commented 3 months ago

Problem Description: Rob is deploying a dataset that requires a few frontend changes.

Expected Behavior/Solution: The frontend will change certain labels and add a new relationship to events. This branch will not be merged into main and the deployment will be from the working branch.

Requirements: On the results page:

Needed for promotion: If an item on the list is not needed, it should be crossed off but not removed.

UAT/LUX Examples:

HAL link examples:

Results page:

Dependencies/Blocks:

Related Github Issues: N/A

Related links: N/A

Wireframe/Mockup: N/A

azaroth42 commented 3 months ago

Shall we just use this issue for other minor updates? Or make a new one?

In particular, and no rush for any of this:

-[ ] Change the descriptions of Datasets, Files and Projects to read: "Records about datasets that match your search" "Records about data files such as CSVs that match your search" and "Records about projects and grants related to datasets that match your search" -[ ] Change the Digital Object search for works header from "This file includes the following datasets" to "This file is part of the following datasets"

roamye commented 3 months ago

@azaroth42 @kamerynB this has an awaiting review label but its status is 'in progress'. OK to move status to reviewable or is this issue still being worked on?

kamerynB commented 3 months ago

@azaroth42 We can make changes in this issue. The descriptions in the first bullet come from the CMS. It looks like the rdata environment points to our existing CMS instance. I could hardcode those specific ones though. And the second bullet is only for Digital Objects and not Physical ones?

kamerynB commented 3 months ago

@roamye This is for Rob's research dataset. There is no need for it to be reviewed but I wanted Rob to know he could take a look at it.

azaroth42 commented 3 months ago

Ahh huh. For a new ticket ... What happens if the CMS is down, or doesn't exist (like in another organization's adoption of LUX)?

But for this ticket -- can you just hard code them? And yes, the second is only for digital not physical -- I don't /think/ there are any physical objects in the dataset

kamerynB commented 3 months ago

@azaroth42 We removed the CMS dependency on the frontend before the migration.

But sounds good!

azaroth42 commented 3 months ago

Right ... but if it gets it from the CMS, what happens when it's not there? There's a default? Or just no explanation?

kamerynB commented 3 months ago

There is no explanation, which is in line with what we have been doing with any config the frontend may be dependent on. The app still works, but some things may be missing.

kamerynB commented 3 months ago

Deployed updates on 4/2/24.