project-lux / lux-frontend

Web front end of LUX
Apache License 2.0
3 stars 0 forks source link

Create "Work Class" facet in Works and Advanced Search #177

Closed roamye closed 2 months ago

roamye commented 6 months ago

Problem Description: We want to create a new facet within the Works tab and Advanced Search that can facet by Work Class.

Expected Behavior/Solution: Users will be able to facet by Work Class values Visual Work , and Textual Work in Works tab and Advanced Search.

Note: this will also need a regression test created. Requirements:

The following Help Text requires a config change in ML:

Needed for promotion: If an item on the list is not needed, it should be crossed off but not removed.

UAT/LUX Examples:

Dependencies/Blocks:

Related Github Issues:

Related links:

Wireframe/Mockup: Place wireframe/mockup for the proposed solution at end of ticket.

Wireframe: Screenshot 2024-04-15 at 4 16 20 PM

New Advanced Search Note: each value selection will display the help text listed above. Image

Work record: image

miketullo95 commented 5 months ago

@roamye same question as #175

roamye commented 5 months ago

Yes this new mock up looks good to me. I will delete the old one. Ty @miketullo95

cc: @prowns

clarkepeterf commented 3 months ago

@kamerynB fyi the facet is called workRecordType and the search field is called recordType

roamye commented 2 months ago

Per UAT: This is approved BUT the Work Class does not show the AS multiple field is set. This bug needs to be a hot fix before deployment.

If this cannot be resolved by the time, it will need to be a priority for next release.

Example for testing: https://lux-front-tst.collections.yale.edu/view/results/works?q=%7B%22AND%22%3A%5B%7B%22recordType%22%3A%22Set%22%7D%2C%7B%22name%22%3A%22saarinen%22%7D%5D%7D No work class facet.

This will also need an index change to include sets. @clarkepeterf @kamerynB

roamye commented 2 months ago

OK the work class set facet now works but I noticed that the numbers do not match up. For example: https://lux.collections.yale.edu/view/results/works?q=%7B%22AND%22%3A%5B%7B%22text%22%3A%22andy%22%2C%22_lang%22%3A%22en%22%7D%2C%7B%22text%22%3A%22warhol%22%2C%22_lang%22%3A%22en%22%7D%5D%7D&sq=andy+warhol

We only have two work class values: visual work and textual work... but the numbers in the facet does not match up to the total number of records... what are the remaining 34 records classified as?

1288 work results 1254 combined results of visual and textual work..

I will make a BH for this issue and close this one as the rest looks good in PROD.