Investigate SI bugs

[kamerynB]

Problem Description: Some SI events aren't working as expected.

Expected Behavior/Solution: This ticket is to investigate what issues are occurring and solutions to those issues. Separate tickets for issues may be required.

Requirements: Investigate the following:

• [x] When you go from search tips or from a featured collections to landing page and then go to About Lux/submit a search result, the event will register with the label "unknown page name". Which should not happen (line 8)
  • From conversation with Kam (6/10), this unknown page name label may be caused by a special characters issues.
• [x] the title does not transfer over to different tabs being selected even though it is still part of the search result. (line 10-15) It does this same thing with submitting a search result too. (line 17)
  • SOLUTION: The links for results tabs do not have state property containing their proper page name. This should be added.
• [x] when a simple search is submitted and facets are opened/selected the results page title will only show for the first facet open/selected but not the other ones or when facets are being deselected/cleared/removed. (line 19-27)
  • NOTE: Opening and closing a facet does not trigger a page event, so I believe the page is not captured. I'm not 100% sure on this but that is my guess.
  • NOTE: "Apply" button on date facets should be refactored to use navigate function and include the state property containing the page name.
  • SOLUTION for checkboxes: Add state property to navigation function for checkboxes. (same solution as for results tabs)
• [x] Sorting the results page will have unknown page name, except for when we sort it by ascending/descending (line 29-32)
  • SOLUTION: Add state property to navigation function. (same solution as for results tabs). Another improvement is to remove the Redirect functionality and just use navigate function from React Router.
• [x] Pagination of search results will only capture the title of the first action.
  • SOLUTION: Add state property to navigation function. (same solution as for results tabs).
• [x] switching to AS from results page, toggling in SS, and navigating to AS from landing page, all have unknown page name.
  • SOLUTION: Add state property to navigation function. (same solution as for results tabs).
• [x] Remove any instance of the url within the event page

Needed for promotion: If an item on the list is not needed, it should be crossed off but not removed.

• [ ] ~Wireframe/Mockup - Mike~
• [ ] ~Committee discussions - Sarah~
• [ ] ~Feasibility/Team discussion - Sarah~
• [ ] ~Backend requirements - TBD~
• [x] Frontend requirements - Kam
• [ ] ~Questions~

UAT/LUX Examples:

• https://docs.google.com/spreadsheets/d/1INlt1C-e3lnJ6ulDb_8w7akFcz9U8WCj1jn_EBzOW8c/edit#gid=404696812 (TABS: STEPS(PRD) and Overview)

Dependencies/Blocks: N/A

Related Github Issues: N/A

Related links: N/A

Wireframe/Mockup: N/A

[kamerynB]

@roamye Can you please elaborate on the first bullet point? Are you anywhere within LUX and then hit the "LUX: Yale Collections Discovery" button in the header or are you taking other steps to get there? Just curious because I'm not seeing the root of the problem on initial testing.

[roamye]

From the initial testing I had started at the landing page and then went to select about lux. Which registered the event under the title: Unknown page name (line 2) -- I believe, correct me if I am wrong, that this is fine since I had directly gone to URL page rather than internally.

eventually I was at the Help Page of LUX and clicked to go back to the landing page. This registered the correct title of: Help (Line 7)

after I was on the landing page, I then selected a featured collection, and its event registered with the title of: Unknown page name.

However, since I moved through the links internally the issue is that the landing page should now register as the title rather than the 'unknown page name'.

Let me know if that makes sense, I will re-word the first bullet point to make it more clear

@kamerynB

[kamerynB]

@roamye Let's walk through it when you are back. I'm not seeing anything locally that sticks out as the problem.

[roamye]

Below are comments for each bullet point listed in the above reqs:

1. This still does not work and shows "unknown page name" when we are within LUX and go to the landing page.
2. Lines 10-15 were replicated and rather than Hogarth Collection being the name for the trigger of event: Works tab it now displays as "Unknown" (line 10). However, the issue of the name being unknown for (11-15) is resolved, as they now shows as the {scope name) result page rather than unknown. so for example: landing page -> hogarth collection -> works (title will say unknown page rather than "hogarth collection") -> People & Groups (title will say "People & Groups results page) -> so on
3. This works well :), anytime an event is faceted it will register with the name: " Results Page faceted" indicating that it was faceted beforehand. If it wasn't faceted before hand it will show as "results page".
4. Lines 29-32 still have the same issues. It should show "results page faceted" when toggling as that was what was previously done. then when you toggle again (ex: list view to grid view) it should say something such as "Results Page Toggled" but it says unknown page name. When selecting the sort by option this will also say unknown page. the one that works corectly is when i then sort from desc to asc which then captures the correct name of "results page sorted".
5. this works well too! label is: "results page paginated"
6. going to advanced search works but the other instances don't. They still display "unknown page name". For example, if I go from advanced search -> switch to simple search -> cancel -> switch to simple search -> continue, both these instances capture as unknown page name. BUT if I go from advanced search -> switch -> continue it will populate the title correctly.
7. From the tests I have done above, the instances where uRLS were in names no longer appear and are replaced with "results page X] So this is all good to me.

I can go through some of these with you if you would like to see my steps.

[kamerynB]

From 6/17/24:

• [ ] 1. I have to look into this more.
• [x] 2. The image link does not have the correct property passed to it for the target page name.
• [x] 3. Done
• [x] 4. The conditional statement should be updated to check that targetName is not undefined or null. Add a state object to the navigate function for list vs grid view.
• [x] 5. Done
• [x] 6. Add state property for when the advanced search is not empty
• [x] 7. Done

[roamye]

comments:

2. OK so going from landing page -> hogarth -> works no longer displays the unknown page name but will display hogarth collection. (line 10) However when I now go from works -> people and groups -> concepts -> scope tabs, it no longer displays the previous name of People & Groups results page. (line 11-15) Also when I go from scope tabs -> submit a simple search for colors, this event no longer has the name of scope results page but will also display unknown page name. (line 17)
3. No longer works??

OK just remembered Peter is re-loading DEV so I will wait to do this afterwards bc maybe it is affecting this?

[kamerynB]

@roamye This wasn't merged with the latest deployment. The current version in DEV is v1.29.0, which does not contain these changes anymore.

[roamye]

@kamerynB - so testing the changes will have to wait until this is deployed in 07/08 milestone?

[kamerynB]

@roamye Most likely. I still have no idea why the landing page events aren't capturing the page name. If, on the 8th, the rest of the changes are good, then I would say we would be able to close this issue and open another for investigating the landing page issues.

[roamye]

Approved by UAT 7/22

[roamye]

PROD Comments:

1. Unknown Page Name continues to display when a user has already been within lux, returns to landing page, and selects a featured collection. (Line 2-8): ---- This continues to be listed as "unknown page name". Weird because I tried 10 minutes earlier and it worked for the Hogarth Collection. But now it doesn't work at all.

2. Title/Label not transferring over when selecting different tabs. (Line 10-15) or when submitting a search (Line 17): ---- Looks good. From the hogarth collection/any collection in the objects tab -> works tab. The works tab will show as the collection name: Alexander Kohut Memorial Collection. This goes for all other event triggered for featured collections that are records. ---- From works tab to any other tab it will now show "Results Page" ---- From hogarth collection (objects) if you submit a search, the Simple Search event now captures the correct title of Hogarth Collection.

3. when a simple search is submitted and facets are opened/selected the results page title will only show for the first facet open/selected but not the other ones or when facets are being deselected/cleared/removed. (line 19-27) ---- This now shows as "Results Page" which is great as it is on the results page. ---- However when it comes to the Creation Date, it does not capture that is on the results page when opening the accordion or hitting "apply"

4. Sorting the results page will have unknown page name, except for when we sort it by ascending/descending (line 29-32) ---- This works well, the events are now captured as "Results Page"

   5. Pagination of search results will only capture the title of the first action. ---- This works well. the events are now captured as 'Results Page" . This is correct since the tests
   6. switching to AS from results page, toggling in SS, and navigating to AS from landing page, all have unknown page name. ---- The other ones are fine. The only one that continues to show "unknown page name" is the Search Switch to Advanced Search. This should says LUX landing page as I was already within LUX.

5. Remove any instance of the url within the event page ---- Instances which used to have a URL label such as those in line 34/51/etc no longer show this issue. They now have a worded label such as "Results Page".

[roamye]

Closing this ticket as the pushes were implemented in PROD.

However - a new issue is needed to investigate why two main issues continue to persist.

1. "unknown page name" continues to display from the landing page when a user has already navigated within LUX. This happens to any featured collections selected, any advanced search and any header tabs selected on the landing page.
2. Date facet filters will label its event with the "unknown page name" when it should show "results page"

Unsure what the effort is like for the two remaining bugs.

@kamerynB