project-lux / lux-frontend

Web front end of LUX
Apache License 2.0
3 stars 0 forks source link

Add Explore Hierarchy widget to Concept and Place pages (from 1723) #25

Open gigamorph opened 8 months ago

gigamorph commented 8 months ago

Problem Description: The current implementation of the entity hierarchy is difficult to understand and does not make complex relationships clear.

July 2023: Teams Chat

Expected Behavior/Solution: There will be a React Flow visualization of the hierarchy based on the below wireframes. Note relationship with #84 (list view updates)

Requirements:

Needed:

UAT/LUX Examples:

Dependencies/Blocks:

Related Github Issues:

Related Links:

Wireframes: 4/16 version: Note: on hover, the icon will probably be outlined or highlighted in some way as a visual indicator that it is a button. Once the user clicks on it, that corresponding entity will become the center of the hierarchy as previously discussed.

image

prowns commented 7 months ago

@miketullo95 - further notes from 2/23/24 team meeting:

Decision: use plus sign to match +

Make sure solution works for/aligns with other hierarchies:

See Also: 2024-02-14: Place and Concept Hierarchy Visualization Deep Dive meeting notes

roamye commented 7 months ago

@kamerynB @miketullo95 Hey Kam. I remember a couple of meetings ago you had a chart where a user could click on the child and parent. Mike was wondering if he could have a screenshot of that to reference for these mockups.

kamerynB commented 6 months ago

Old wireframes: Initial view: image

Showing expanded grandparents: image

Showing expanded siblings image

kamerynB commented 6 months ago

@miketullo95 Here is what I have so far as a proof of concept with React Flow. Screenshot 2024-04-02 at 9 36 25 AM

miketullo95 commented 6 months ago

@prowns @kamerynB @roamye wireframes uploaded. due to this tickets complexity, this may need to be discussed as a group.

prowns commented 6 months ago

@miketullo95 and @kamerynB - Some feedback from R/S/J review of the mocks...

We would need a new icon for this.

kamerynB commented 6 months ago

@azaroth42 @prowns @jffcamp Why not just do a dropdown button similar to the advanced search button on the landing page. The three dots would be an arrow.

Screenshot 2024-04-10 at 3 12 26 PM

prowns commented 6 months ago

I don't mind that, but the goal was eliminating that extra click. That said, I like the arrow better than three dots. On the left side, should the arrow be on the left, with the selection box expanding out to the left side? This also implies "up" the hierarchy.

Labels would need to change. How about: View Record, Explore More

@miketullo95 - what are your thoughts. #agenda for 4/12

prowns commented 6 months ago

@kamerynB - iterating mocks via teams. Will update ticket when consensus is reached.

roamye commented 6 months ago

There are two options up for discussion: Option 1: The name of the entity is a link to that entity page and the arrow is a button to a menu that allows a user to view hierarchy OR it's a button that takes the user to that entity's hierarchy. (whichever we choose) image image

Option 2: The text is a button that shows a dropdown menu for user to view options for that entity image image

After it has been discussed I will move the mockups to the issue body. Conversation in Teams

azaroth42 commented 6 months ago

Option 1: 25-diagram

Option 2: 25-version2

prowns commented 6 months ago

I like option 2 with the icon as a button.

prowns commented 6 months ago

Older mocks here for reference: Updated wireframes to be uploaded by @miketullo95. Default view 25 - closed

When a user clicks the menu icon, shows two options. 25 - open

When user clicks "show more" it shows 5 more items (placeholder data, not for UAT) 25 - show less

When a user clicks on "Explore Hierarchy" (and when an item has no parents) 25 - new record

kamerynB commented 5 months ago

Update 5/2/24: The hierarchy is not in DEV yet but the following is now working locally:

  1. Show More/Less in List view and Chart view
  2. Connectivity between the List and Chart, ie when selecting to view an entity's hierarchy or clicking show more/less will be reflected in both views when switching back and forth
  3. Show all X children results button
  4. Show entity's hierarchy button
  5. Entity links
  6. Fullscreen view with some minor bugs

cc: @prowns @jffcamp @roamye

kamerynB commented 5 months ago

Update 5/8: The first iteration of the hierarchy has been deployed to DEV. Please feel free to leave feedback here. @prowns @jffcamp @roamye

jffcamp commented 5 months ago

Weird rendering for this: https://lux-front-dev.collections.yale.edu/view/concept/cc768f79-990b-46c7-83af-a99e1b0b6e08

kamerynB commented 5 months ago

@jffcamp Is the below screenshot what you see? And if so, is it the visual works by material or technique record that is weird? What I'm thinking is if I set a width on each node, then that might mitigate long titles from rendering weird edges (edges being the lines connecting the nodes/entity links).

Screenshot 2024-05-16 at 1 56 27 PM

jffcamp commented 5 months ago

Yes. It is the Visual Works by material or technique.

prowns commented 5 months ago

Moving visualization around drops artifacts: image

Seen here: https://lux-front-dev.collections.yale.edu/view/concept/213fde35-557e-4a25-a1d9-3e7b94215fde

roamye commented 4 months ago

The record Algeria in DEV: https://lux-front-dev.collections.yale.edu/view/place/b544756d-3e3c-4a88-8a0c-f5a26b22b353, does not accurately reflect the children when selecting the branch of the child "Constantine (Province)". This happens within the list view and the hierarchy view. Examples below:

List view of Constantine (Province): image

Hierarchy View of Constantine (Province): image

What should show for the record Constantine (Province): image

Note: I clicked on Constantine (Province) record from the Algeria record and it showed as the two photos above rather than immediately as the third photo. I had to refresh it for it to reflect it properly.

kamerynB commented 4 months ago

@roamye Thank you for pointing out. The next deployment to DEV, which is TBD, will contain the fix.

roamye commented 3 months ago

@kamerynB - is mike/heather still needed for this ticket? Also wanted to confirm if this was removed from the 07/08 milestone because of paginations (https://github.com/project-lux/lux-frontend/issues/252). What else is left for this to move forward?

kamerynB commented 2 months ago

@roamye I have to work on accessibility and overall functionality. It's not a facets issue since the children results come from a search link HAL link. I'll add it to the 8/19 milestone. It won't be done for the current milestone.

kamerynB commented 2 weeks ago

@jffcamp @prowns What is the urgency of this ticket? I have not been working on this as other issues have taken priority. Is this something I should return to for the next deployment?

cc: @roamye

jffcamp commented 2 weeks ago

@kamerynB, it would be great to get this critical ticket completed. So yes, if you can work on it for the next deployment that would be swell.

roamye commented 1 week ago

New visualizations have been added into DEV. Feedback is based off of the record: Southern Cone of South America Feedback on Functionality:

  1. Hierarchy Window Closes when selecting a parent (Mentioning this so we have record of it, but I know we are aware of this.) -- 1. Click on Southern Cone of South America -- 2. Click Full Screen icon -- 3. Select Chile

Feedback (general):

  1. When places/concepts are both children and parents there should be an indicator of that since nodes are listed on the children side. -- 1. Click on Southern Cone of South America -- 2. Notice how Uruguay is listed on the children side only.

  2. Show more/show less does not list additional parent records. -- 1. Click on Southern Cone of South America -- 2. Select Show More -- 3. Notice the records from both sides stay the same. (Note: ** the line connection from Brazil does disappear but given there is no indication this is also a parent record it is hard to notice. )

  3. Hierarchy map is not consistent. -- 1. Click on Southern Cone of South America -- 2. Select Chile -- 3. Select southern cone of south America -- 4. notice how it differs from what was presented originally (layout wise) when selecting the link in step 1.

kamerynB commented 6 days ago

Making notes in response to Amy's comment.

Feedback on Functionality:

  1. Yes, known issue. Thank you for recording it!

General Feedback:

  1. This is because Uruguay is a child and parent of the entity but it does not appear in the first 5 children being rendered.
  2. It technically does. Brazil is a parent and child but it is not listed in the first 5 parents rendered. When you hit Show More, it becomes visible to the frontend and therefore the (poorly placed) connection is made.
  3. I have yet to figure out how to make ReactFlow render the nodes in a consistent manner. Right now, it is choosing the coordinates of the nodes based on dagre, another Javascript library.

Notes: Issues 1 and 2 of the General Feedback are because a parent is a child or a child is a parent and they are not being rendered at first because they are not part of the initial 5 parents/children displayed. This should be discussed at the 10/18/24 team meeting.

cc: @roamye

roamye commented 4 days ago

From IT Team Meeting 10/18 (notes here):