project-lux / lux-frontend

Web front end of LUX
Apache License 2.0
3 stars 0 forks source link

Add pagination to facets on results pages #252

Closed kamerynB closed 3 months ago

kamerynB commented 5 months ago

Problem Description: Facets are currently causing performance issues. This issue will cover all facets.

Expected Behavior/Solution: ML will be returning the activity streams and pagination will now be required for facets containing lists.

5/29 UAT: For date dacets, FE will need two requests instead of one. One for the first and one for the last page. The results will be returned in order so that the first results on the first page is the earliest year of the range, and the last result on the last page will be the latest year of the range.

Requirements:

Needed for promotion: If an item on the list is not needed, it should be crossed off but not removed.

UAT/LUX Examples:

Dependencies/Blocks:

Related Github Issues:

Related links: N/A

Wireframe/Mockup: Wireframe is not needed as it will look and behave as it did before this change it completed.

roamye commented 4 months ago

Agenda

kamerynB commented 4 months ago

5/31 decision regarding date facets and HAL links that require dates: For facets on the results page, the frontend will make a request to both the first page and last page of the date results to get the earliest and latest dates. From there, the frontend can generate the range input fields with a minimum and maximum year.

For timeline lists, the frontend can pagination through the results in the same manner it will paginate on the results facets.

This will still impact the timeline graph but as that is not implemented yet, we will reevaluate solutions when it is necessary.

cc: @jffcamp @prowns @roamye @clarkepeterf @azaroth42

roamye commented 4 months ago

From 5/31 IT meeting:

If Performance Test | https://github.com/project-lux/lux-marklogic/issues/162, passes then we can add this tix to the 6/10 milestone.

Separate ticket for the date facets ONLY is: https://github.com/project-lux/lux-frontend/issues/262

roamye commented 3 months ago

Approved by UAT

roamye commented 3 months ago

reviewed 7/16 Looked good in prod, closing.