project-lux / lux-frontend

Web front end of LUX
Apache License 2.0
3 stars 0 forks source link

Add search link to show archival sets results containing digital image thumbnails (from 1728) #28

Closed gigamorph closed 5 months ago

gigamorph commented 8 months ago

Problem` Description: This is an enhancement to the explore hierarchy feature. Although we now have a icon to indicate archival objects that have digital images, there is no easy way for a user to browse the digital images on the archival collection level.

Expected Behavior/Solution: The hierarchy will have a link to the results page where a user can view records with images. The HAL link will have to cover objects and works.

Requirements:

Needed for promotion:

UAT/LUX Examples:

Dependencies/Blocks:

Related Github Issues:

Related links: Bugherd: - https://www.bugherd.com/projects/284041/tasks/851

Wireframe/Mockup: Image

ar2674 commented 8 months ago

@miketullo95 should this be assigned to you instead?

roamye commented 7 months ago

From old tix(https://git.yale.edu/lux-its/lux-web/issues/1728): 12/5/23 Per ticket forming - ready to promote as blocked and needing HAL link completed.

prowns commented 6 months ago

@miketullo95 - this is for you next; mockup needs updating.

miketullo95 commented 6 months ago

mock updated @prowns 😄

kamerynB commented 6 months ago

This will require 2 links. One for View objects from this archive with images and the other being View works from this archive with images. The hierarchy shows both works and objects.

cc: @miketullo95

prowns commented 6 months ago

@kkdavis14 - would there ever be works with images in archival hierarchy? I'm thinking not. Only the archival object is digitized.

kkdavis14 commented 6 months ago

@prowns I don't think so, archival Objects don't carry any Works, and I think all the Works that are Archives are top level or Series level collections, not Visual Items or Textual Works.

roamye commented 5 months ago

I looked at the third UAT example in tst (here) and it shows me an error. Is that supposed to happen? @kamerynB

kamerynB commented 5 months ago

@roamye I'm not sure why those search links are in the UAT block. The ones to be concerned about are the entity links, ie the first 2 UAT examples. The archives in those entities should have a link saying View records from this archive with images and those links should be valid. I'm not sure where those search links came from.

roamye commented 5 months ago

@kamerynB looks like it was added back in 2023 (old issue). I will strike them out. Thanks Kam.

jffcamp commented 5 months ago

@kamerynB - the link needs to either be bolded as a hotfix or backed out. Also, add a little more space between the list and the link.

kamerynB commented 5 months ago

@jffcamp A PR for the hotfix is already open.

What it will look like: Screenshot 2024-05-16 at 10 07 30 AM

roamye commented 5 months ago

@kamerynB I believe the archive collection name also needs to be bold to reflect the wireframe in the mockup.

cc: @jffcamp

kamerynB commented 5 months ago

@roamye I've included that in #27. The current entity link has not been bolded since I deployed the SI changes as I accidentally removed that styling when making those changes. That bug was not introduced with this deployment.

cc: @jffcamp

jffcamp commented 5 months ago

@kamerynB - Thanks. Please deploy.

kamerynB commented 5 months ago

Deployed!

cc: @roamye @jffcamp

roamye commented 5 months ago

Approved by UAT

roamye commented 5 months ago

Looks good in prod, closing.