project-lux / lux-frontend

Web front end of LUX
Apache License 2.0
3 stars 0 forks source link

Fix front end and hierarchy rendering issues. #297

Closed roamye closed 1 week ago

roamye commented 1 month ago

Problem Description:

  1. records are not re-rendering so it will show incorrect data under parents/children when going back to a previous record.

  2. Show More/Show Less button is showing even when there are only 5 parents

  3. ~The explore record renders parent/childrens label when data does not exist.~ (has been moved to 332)
    ~For the Concept record Andy Warhol, 1928-1987 the explore section shows "Parents" but does not list any of it underneath it. This happens in all env.~ ~Additionally, if you click on the component term exhibitions and click return then the original record now lists incorrect information under the explore section. However it still does not list any parent information.~ ~This ticket serves as a research ticket to figure out why this is happening and to propose a potential solution.~

Expected Behavior/Solution:

Requirements:

Needed for promotion: If an item on the list is not needed, it should be crossed off but not removed.

UAT/LUX Examples: Issue 2:

Issue 3:

~Issue 1:~

Dependencies/Blocks: N/A

Related Github Issues: N/A

Related links:

Wireframe/Mockup: Current Issue 2: image Expected Issue 2: image

Current when there are 5 parents:

Screenshot 2024-07-30 at 2 18 32 PM

Expected:

Screenshot 2024-07-30 at 2 18 47 PM
roamye commented 1 month ago

There are two different issues happening in this ticket. 1) parent information not rendering 2) explore information rendering on original page when you select a new page and go back to it.

I was unsure if these issues are related to each other so I put them both on here. If you would like them to be separate let me know and I can separate them.

@kamerynB

kamerynB commented 1 month ago

@roamye

  1. There is no parent information in the record (found in the /broader property in the JSON). The frontend issue is then that it should not render the hierarchy component if there are no parents and children.
  2. That looks like a rendering issue on the frontend. That hierarchy component isn't being re-rendered upon going back.

The 2 issues are unrelated, as fixing one will not impact the other. However, the second one is a simple fix. I just tested it locally and it involves changing one line of code. They can be completed in one GH issue.

roamye commented 4 weeks ago

These will need to be separated into three issues. 1 important 2/3 critical (8/7 UAT)

kamerynB commented 4 weeks ago

@roamye These issues can remain as one issue. I will tackle them together. I would mark this issue as Critical if the majority are considered critical.

roamye commented 3 weeks ago

@kamerynB - I created this ticket: https://github.com/project-lux/lux-frontend/issues/332, it tackles the first issue on 297 and includes its separate UAT.

roamye commented 1 week ago
  1. looks good in prod.
  2. looks good in prod. Closing.