project-lux / lux-frontend

Web front end of LUX
Apache License 2.0
3 stars 0 forks source link

Add support for caused_by data point #309

Open kamerynB opened 1 month ago

kamerynB commented 1 month ago

Problem Description: The data contains a property called caused_by that is not being rendered.

Expected Behavior/Solution: Add support for the caused_by data point.

Requirements:

Needed for promotion: If an item on the list is not needed, it should be crossed off but not removed.

UAT/LUX Examples:

Dependencies/Blocks: N/A

Related Github Issues:

Related links:

Wireframe/Mockup: Current: Screenshot 2024-07-31 at 9 59 38 AM

Expected: Screenshot 2024-07-31 at 9 58 13 AM

image

roamye commented 1 month ago

Brewer's example: https://lux.collections.yale.edu/data/text/614f2504-a240-4720-8e2a-d87d9bf7eb5f

Needs to be updated. @kamerynB

kamerynB commented 1 month ago

After discussion in the 8/7 team meeting, the label should be "Caused By", not "Contributors".

prowns commented 3 weeks ago

UAT: Blocked. Need to update labeling recommendation and mockup from 8/22 Data mtg. Share with YUL/Data members to confirm, then proceed with work.

Notes from Data meeting:

@roamye - can you create a new mockup for https://lux.collections.yale.edu/view/text/614f2504-a240-4720-8e2a-d87d9bf7eb5f that includes the following new section?

Creation Caused By | Events | Brewers' Industrial Exhibition (1876 : Philadelphia) ........................................ | Additional Events | Centennial Newspaper Exhibition (1876 : Philadelphia, Pa.)

azaroth42 commented 3 weeks ago

Could we also try: Creation Resulted from Event: Additional Events:

Thanks!

roamye commented 3 weeks ago

@prowns - image

@azaroth42 - image

Was unsure of the placement so I put it under Language for now. This was made from the record: https://lux.collections.yale.edu/view/text/614f2504-a240-4720-8e2a-d87d9bf7eb5f

prowns commented 2 weeks ago

@kamerynB - do you know whhere this will be placed?

azaroth42 commented 2 weeks ago

Sarah's version doesn't work because there could be additional information about people, places and times.

It would need to be:

Creation
                      Caused by Event:     Brewers
                      Additional Events:   Centennial
roamye commented 2 weeks ago

@prowns & @azaroth42 - do we know which version we would want to do? If it is Sarah's I can re-update it. If not, I can just leave the screenshots above as is for now.

prowns commented 2 weeks ago

@roamye - please use Rob's version.

kamerynB commented 2 weeks ago

@azaroth42 Your example in the comment here isn't feasible with how the data is returned. What property is the frontend looking for to determine the labels? Or is it just based on the order they are parsed? The classified_as properties do not clarify this either.

azaroth42 commented 2 weeks ago

classified_as -- creator = the first one, contributor = the others

kamerynB commented 2 weeks ago

@azaroth42 As we are not using data constants anymore and to prevent the frontend from requiring an extra API call, the corresponding /classified_as should have a nested equivalent with the appropriate AAT values. In this example, there are no AATs for each /part[index]/classified_as.

roamye commented 2 weeks ago

A data pipeline issue will need to be created as it is blocking this ticket. Will have to move it to the next milestone (not 09-09).

Promoting as blocked and rob's mockups can replace the ones above.

kamerynB commented 2 weeks ago

Thank you all!